1fanwang commented on code in PR #51246:
URL: https://github.com/apache/arrow/pull/51246#discussion_r3962916296
##########
python/pyarrow/io.pxi:
##########
@@ -1101,6 +1101,7 @@ cdef class MemoryMappedFile(NativeFile):
----------
new_size : new size in bytes
"""
+ self._assert_open()
check_status(self.handle.get().Resize(new_size))
Review Comment:
Leaving this out. The `Resize` call is pre-existing and unchanged here;
releasing the GIL on a mutating method opens a window for a concurrent
`close()`, so it wants its own change with its own reasoning rather than riding
along on a crash fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
