M-Tesla commented on PR #11017: URL: https://github.com/apache/arrow-rs/pull/11017#issuecomment-5593852753
Thank you for the review, @etseidl. I really appreciate you taking the time, especially while this behavior is still being settled. I'll follow the approach you outlined: - Keep the incompatible logical type as `_Unknown` instead of stripping it to `None` - Leave column statistics in place, so callers can ignore them or use them if they have out-of-band type information - Use `UNDEFINED` for the sort order (the `SIGNED` placeholder in `BasicTypeInfo` was only a dummy before recomputing sort order, and I agree that is the wrong default) - Switch the test over to the parquet-testing file from apache/parquet-testing#122 I'll keep the reader option with the current default (error), matching what @alamb suggested on the issue, and I will post a short note there as well so the discussion lives with the spec question. Thank you again for the guidance. I'll update the PR along these lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
