ax1s-x1zz commented on PR #11006: URL: https://github.com/apache/arrow-rs/pull/11006#issuecomment-5594564373
Thanks for the honest feedback, everyone — I've been thinking about this over the weekend and I think you're right. A key fact I should have surfaced earlier: the DataFusion PR that motivated this (#12448) has since been **merged** — it now uses arrow-rs's interval parsing for the actual expression evaluation and fixed the `interval '5 day' hour` case without needing any bare-unit relaxation here. So the original use case this was built for has already been resolved on the DataFusion side, and I don't have a concrete downstream consumer that would depend on this behavior. Given that, plus the points made above (Postgres's parser being permissiveness here is arguably a quirk rather than a contract; Spark and DuckDB both reject it), I agree this isn't worth broadening the public parser for. I'll close this PR as wont-fix. I'll also ask to close apache/arrow-rs#6390 since the motivating case no longer needs it — happy to hear if anyone disagrees, but I don't want to leave a stale open issue around it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
