tadeja commented on PR #47498: URL: https://github.com/apache/arrow/pull/47498#issuecomment-5601019229
Thanks @severo, also for fixing numpydoc validation PR03 order error that finally showed up here in the CI Numpydoc job https://github.com/apache/arrow/actions/runs/34203717165/job/101988921363#step:6:4415 ```shell pyarrow.parquet.core.write_table PR03: Wrong parameters order. Actual: ('table', ..., 'data_page_size', 'flavor', ..., 'write_time_adjusted_to_utc', 'max_rows_per_page', 'bloom_filter_options', 'use_content_defined_chunking', '**kwargs'). Documented: ('table', ..., 'data_page_size', 'max_rows_per_page', 'flavor', ..., 'use_content_defined_chunking', 'write_time_adjusted_to_utc', 'bloom_filter_options', '**kwargs') ``` - Apparently `max_rows_per_page` is out of order on main for a while, but numpydoc validation skips PR03 order check if a documented parameter is missing (= [PR02 check is still disabled on Arrow](https://github.com/apache/arrow/blame/0d8f1b9929462364b4fe48a68891d468e0b156a8/compose.yaml#L1559)). Because `use_content_defined_chunking` was present in docstring but missing from the signature, the order check PR03 never ran for `write_table`! -> I'll open a separate issue for PR02 skipping PR03. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
