Copilot commented on code in PR #51258:
URL: https://github.com/apache/arrow/pull/51258#discussion_r3967297646
##########
cpp/src/gandiva/tests/projector_test.cc:
##########
@@ -2110,7 +2114,7 @@ TEST_F(TestProjector, TestToDate) {
// Build a projector for the expressions.
std::shared_ptr<Projector> projector;
- auto status = Projector::Make(schema, {expr}, TestConfiguration(),
&projector);
+ auto status = Projector::Make(schema, {expr}, config, &projector);
EXPECT_TRUE(status.ok());
Review Comment:
Using EXPECT_TRUE(status.ok()) here allows the test to continue with a
potentially null Projector, which can lead to a crash and obscure the real
failure. Prefer ASSERT_OK(status) (or ASSERT_OK(Projector::Make(...))) to stop
the test immediately on failure.
This issue also appears on line 2132 of the same file.
##########
ci/docker/conda-cpp.dockerfile:
##########
@@ -28,6 +28,7 @@ RUN /arrow/ci/scripts/install_minio.sh latest /opt/conda
COPY ci/conda_env_cpp.txt \
ci/conda_env_gandiva.txt \
/arrow/ci/
+RUN echo "Force rebuild"
Review Comment:
This adds an extra Docker layer but doesn’t provide a durable cache-busting
mechanism, and the preceding COPY of conda_env_* files already invalidates the
cache when those files change. Removing this keeps the image smaller and avoids
unnecessary rebuild steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
