HuaHuaY commented on code in PR #51266:
URL: https://github.com/apache/arrow/pull/51266#discussion_r3969663985
##########
cpp/src/gandiva/engine.cc:
##########
@@ -422,10 +432,15 @@ Status Engine::LoadPreCompiledIR() {
/// Parse the IR module.
llvm::Expected<std::unique_ptr<llvm::Module>> module_or_error =
llvm::getOwningLazyBitcodeModule(std::move(buffer), *context());
- // NOTE: llvm::handleAllErrors() fails linking with RTTI-disabled LLVM builds
- // (ARROW-5148)
- ARROW_RETURN_NOT_OK(VerifyAndLinkModule(*module_,
std::move(module_or_error)));
- return Status::OK();
+ ARROW_ASSIGN_OR_RAISE(
+ auto src_ir_module,
+ AsArrowResult(module_or_error, "Failed to verify and link module: "));
+
+ // Built-in bitcode is JIT-compiled on the runtime host. Do not retain the
target
+ // selected by Clang when the bitcode was built.
Review Comment:
I think deleting the build target attributes is the right move. We shouldn't
include information about the pre-compilation environment in the pre-compiled
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
