alamb commented on a change in pull request #325:
URL: https://github.com/apache/arrow-rs/pull/325#discussion_r637135868
##########
File path: parquet/src/encodings/decoding.rs
##########
@@ -427,6 +425,7 @@ impl<T: DataType> DeltaBitPackDecoder<T> {
);
assert!(loaded == self.values_current_mini_block);
} else {
+ self.deltas_in_mini_block.clear();
Review comment:
I don't understand the need for this change -- was calling `clear()` a
major bottleneck? Or was it having to reinitialize the entire
`deltas_in_mini_block` to `default()` in the `self.use_batch` branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]