zeroshade commented on PR #833: URL: https://github.com/apache/arrow-go/pull/833#issuecomment-5614903448
> I have fixed the perf issue, now the row buffering only happens at the top-level struct, and we avoid re-decoding nested rows. Had to add some plumbing to Builder for that. Look at commit Don't buffer rows on child struct builders Can we add a benchmark for this (and post the main vs this PR result of the benchmark just to confirm)? > What I didn't fix (on purpose) That's fair, this logic is sound and makes sense to me. I'm good with it. > Also intended behavior. I added a comment that the decoder behaves like the default C++ decoder, with ParseOptions::Ignore, which ignores unknown keys. Gotcha, this is fine then. Following the default behavior of the c++ decoder is more desirable anyways. Thanks! So you just gotta fix the linting issue and then we're all good here :) Thanks for putting up with the reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
