emecii opened a new pull request, #4774: URL: https://github.com/apache/arrow-adbc/pull/4774
## Summary - track the version actually accepted during driver negotiation - for drivers negotiated down to ADBC 1.0, implement integer and double setters through the legacy string setter - preserve native ADBC 1.1 setters and keep byte setters unsupported - use locale-independent, round-trippable numeric formatting across database, connection, and statement options - keep the required CGo driver-manager source mirror synchronized The compatibility tests cover all three object types, queued pre-init options, integer limits, floating-point precision and signed zero under a comma decimal locale, driver error status, ADBC 1.1 behavior, and embedded-NUL byte rejection. The compatibility test file is also touched by #4317, but that PR only changes the existing struct-size assertion hunk; these additions are disjoint. ## Testing - `adbc-version-100-compatibility-test`: 8/8 passed (the same binary linked to the unmodified library fails exactly the two new fallback tests) - `adbc-driver-sqlite-test`: 123 passed, 15 capability skips - `adbc-driver-manager-test`: 174 passed, 28 skips, 2 failures; both failures (`MultiDriverTest`, `ImplicitUri`) require the PostgreSQL shared library absent from this SQLite-only build and match the clean baseline - `SKIP=dotnet-format uvx pre-commit run` passed all applicable staged-file hooks; `dotnet-format` was skipped because `dotnet` is unavailable and no C# files changed - CGo source synchronization hook and `git diff --check` passed `go test ./...` was not available locally because the host has no Go toolchain; hosted CI can cover the synchronized CGo copy. ## AI assistance OpenAI Codex was used to help implement and test this change. Closes #4115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
