ianmcook commented on pull request #10375:
URL: https://github.com/apache/arrow/pull/10375#issuecomment-846261638


   The fact that `is_inf` returns false for `NaN` is inconvenient because its 
negation returns true.
   
   Both R and NumPy have separate functions to test for finite and invite 
values, and these all return false for `NaN`:
   ```r
   > is.infinite(NaN)
   [1] FALSE
   > is.finite(NaN)
   [1] FALSE
   ```
   ```python
   >>> np.isinf(np.nan)
   False
   >>> np.isfinite(np.nan)
   False
   ```
   I wonder if this suggests we should also make an `is_fin` or `is_finite` 
kernel to avoid this problem of negation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to