raulcd commented on code in PR #51280: URL: https://github.com/apache/arrow/pull/51280#discussion_r3978615294
########## cpp/examples/minimal_build/CMakeLists.txt: ########## @@ -49,3 +49,14 @@ if(ARROW_LINK_SHARED) else() target_link_libraries(arrow-example PRIVATE Arrow::arrow_static) endif() + +option(ARROW_EXAMPLE_S3 "Verify S3 and static linking" OFF) +if(ARROW_EXAMPLE_S3 AND TARGET Arrow::arrow_static) + add_executable(arrow-example-s3-static example.cc) + target_compile_definitions(arrow-example-s3-static PRIVATE ARROW_EXAMPLE_S3) + target_link_libraries(arrow-example-s3-static PRIVATE Arrow::arrow_static) + find_package(ArrowS3 QUIET) + if(TARGET ArrowS3::arrow_s3_static) Review Comment: this won't do anything here, right? Doesn't this has to be executed on top of my branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
