Copilot commented on code in PR #51247:
URL: https://github.com/apache/arrow/pull/51247#discussion_r3978804682
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -246,6 +246,12 @@ def test_list_functions():
assert "add" in pc.list_functions()
+def test_call_tabular_function_rejects_invalid_registry():
+ with pytest.raises(TypeError,
+ match="func_registry must be a FunctionRegistry"):
+ pc.call_tabular_function("", None, 1)
Review Comment:
This regression test currently executes the invalid `func_registry` call
in-process. If the crash regresses, it can take down the entire pytest run (the
issue report was a SIGSEGV), and it also contradicts the PR description that
says the regression is exercised in a subprocess. Consider running the call in
a subprocess and asserting it exits with a normal Python exception (non-zero
return code and stderr containing the TypeError), and mark it with
`@pytest.mark.processes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
