HuaHuaY commented on code in PR #51286:
URL: https://github.com/apache/arrow/pull/51286#discussion_r3979761074
##########
cpp/src/arrow/dataset/file_csv.cc:
##########
@@ -373,6 +373,7 @@ bool CsvFileFormat::Equals(const FileFormat& format) const {
checked_cast<const CsvFileFormat&>(format).parse_options;
return parse_options.delimiter == other_parse_options.delimiter &&
+ parse_options.delimiter_string ==
other_parse_options.delimiter_string &&
parse_options.quoting == other_parse_options.quoting &&
Review Comment:
I'm not entirely sure that semantic equality is what we need here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
