bharadwaj-pendyala commented on issue #11028:
URL: https://github.com/apache/arrow-rs/issues/11028#issuecomment-5619939838
I'd land Option A on its own. `PageIndexProvider` already defaults
`is_complete`, so a defaulted `heap_size(&self) -> usize { 0 }` is additive for
existing implementors. `memory_size` can replace `downcast_ref::<PageIndex>()`
at `parquet/src/file/metadata/mod.rs:242` with the trait call. Built-in
`PageIndex` would report the same number using its existing private `HeapSize`
impl.
Both prior attempts died on scope rather than merit: #9138 was a 2k-line new
crate that never got reviewed, and #9842 stalled on where the trait should
live. Public `HeapSize` still seems worth doing, but it doesn't have to gate
accounting for custom providers. Does leaving public `HeapSize` for a follow-up
fit what you had in mind?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
