Jay846 commented on PR #50976: URL: https://github.com/apache/arrow/pull/50976#issuecomment-5621665826
Hi @pitrou and @HuaHuaY, As informed prior I have pushed the updates incorporating all of @pitrou's feedback in commit 6bd6303 (renamed struct to CastListViewToVarList, added template documentation, added DCHECK_NE, factored out offset allocation, simplified end_offset, and expanded test cases with nulls and zero-length arrays). I noticed the Dev / Lint check failed due to a minor clang-format formatting preference. I can push a quick formatting-only commit to make Dev / Lint green whenever you'd like me to, along to that other 4 are Flaky / Infrastructure Failures as of my best knowledge. Please let me know if any other adjustments are needed and also correct me too if I am wrong anywhere! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
