kentkwu opened a new pull request, #477:
URL: https://github.com/apache/arrow-js/pull/477
## Summary
`@types/glob` is a deprecated stub package that has had no effect on this
repo for some time. glob v9 and later ship their own type definitions, and npm
marks every published version of the stub as deprecated with the message "glob
provides its own type definitions, so you do not need this installed."
- Remove `@types/glob` from `devDependencies`, along with its transitive
`@types/minimatch`
- No source changes: the two `glob` consumers, `bin/integration.ts` and
`gulp/test-task.js`, both use the v9+ named-export API that only the bundled
types describe
Confirmed with `tsc --traceResolution` that `import { glob } from 'glob'`
resolves to `node_modules/glob/dist/esm/index.d.ts` from glob 13.0.0, both
before and after the change, so the stub was already being ignored.
## Test Plan
- [x] `tsc --noEmit --strict` against a `glob` import, clean
- [x] `npm run lint` (autofix, no changes)
- [x] `npm test` — full gulp suite, 13 tasks, all targets (ts, src,
apache-arrow; es5/es2015/esnext across cjs, esm, umd)
## Related
- Supersedes apache/arrow-js#219, which proposes bumping the stub to
`@types/[email protected]` — itself a deprecated release
The `Integration` check is expected to fail on this PR for reasons unrelated
to the diff: conda-forge's `go` package currently resolves to its `nocgo`
build, so the shared `conda-integration` image builds Go without cgo and
`arrow_go_integration.so` cannot be built. apache/arrow#51287 tracks the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
