Copilot commented on code in PR #51304:
URL: https://github.com/apache/arrow/pull/51304#discussion_r3988808172
##########
cpp/src/parquet/parquet.thrift:
##########
@@ -637,6 +649,14 @@ enum Encoding {
Support for INT32, INT64 and FIXED_LEN_BYTE_ARRAY added in 2.11.
*/
BYTE_STREAM_SPLIT = 9;
+
+ /** Adaptive Lossless floating-Point (ALP) encoding for FLOAT and DOUBLE.
+ Losslessly converts decimal-like floating-point values to integers via
+ decimal scaling, then applies Frame of Reference (FOR) encoding and
+ bit-packing; values that cannot be converted losslessly are stored as
+ exceptions. See Encodings.md for the detailed specification.
+ */
+ ALP = 10;
Review Comment:
`ALP = 10` is added only to the generated `format::Encoding`, while the
public `parquet::Encoding` mirror still has `UNDEFINED = 10` and
`FromThriftUnsafe` performs an identity `static_cast`. Any ALP value read from
metadata will therefore be interpreted as `UNDEFINED` (and `EncodingToString`
will return `UNKNOWN`). Please update the mirrored enum/sentinel and string
conversion with this schema change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
