fallintoplace opened a new pull request, #1315:
URL: https://github.com/apache/arrow-go/pull/1315
## What does this change?
- `doAppendBinary` and `doAppendFixedSize` still called
`MemoTable.GetOrInsert` for every value.
- The memo is already a `TypedMemoTable[[]byte]`.
- Use `InsertOrGet` directly, like the numeric hash paths.
- Null handling is unchanged.
## Why
This removes the `[]byte` to `interface{}` call-site conversion from the
compute dictionary and unique kernels. It also makes the typed binary memo path
reachable from these hot loops.
## Coverage
- Existing string and binary dictionary tests cover the variable-width path.
- Added a fixed-size-binary dictionary test.
- Added string and 16-byte fixed-size-binary benchmarks.
No public API changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
