kevinushey opened a new pull request, #4780:
URL: https://github.com/apache/arrow-adbc/pull/4780
Profile interpolation currently constructs a `std::regex` to expand `{{
env_var(NAME) }}` expressions. Replace it with a linear scanner that preserves
whitespace trimming, overlapping delimiters, literal malformed braces, and
existing error messages. This removes the regex construction path implicated in
#4638.
Keep the Go driver manager copies synchronized and remove the remaining
unused `<regex>` includes. Add regression coverage for delimiter edge cases,
whitespace, adjacent substitutions, embedded NULs, long brace sequences,
errors, and nonrecursive expansion.
Validation:
- Driver manager suite on macOS: 179 passed, 28 skipped.
- A temporary differential harness compared status, output, and errors
against the original implementation for 187,381 exhaustive and randomized
inputs with AddressSanitizer and UndefinedBehaviorSanitizer; all matched.
- Pre-commit checks passed for formatting, cpplint, licenses, spelling,
whitespace, and C/Go source synchronization. The always-run C# formatting hook
could not run because `dotnet` is unavailable; no C# files changed.
The CRAN GCC 16 sanitizer environment was not reproduced locally.
Closes #4638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
