Copilot commented on code in PR #51315:
URL: https://github.com/apache/arrow/pull/51315#discussion_r3997316980
##########
r/R/arrow-package.R:
##########
@@ -180,6 +180,13 @@ s3_finalizer <- new.env(parent = emptyenv())
configure_tzdb <- function() {
if (requireNamespace("tzdb", quietly = TRUE)) {
+ if (runtime_info()[[3]] == "true") {
+ # GH-51267: builds reading the OS timezone database (C++20 std::chrono,
+ # or the vendored library built against the OS tzdata) cannot use a
+ # downloaded database, and their timezones already work — skip the
+ # vendored path instead of surfacing a false startup failure.
+ return(invisible())
+ }
Review Comment:
Because this check is nested under `requireNamespace("tzdb")`, a std::chrono
build with no R `tzdb` package still reaches the `else` branch below and emits
the false “Timezones will not be available” startup message. Check
`using_os_timezone_db` before testing for the optional package so OS-backed
builds return without requiring or warning about `tzdb`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
