kou commented on code in PR #4781:
URL: https://github.com/apache/arrow-adbc/pull/4781#discussion_r3997804024
##########
c/driver_manager/meson.build:
##########
@@ -20,7 +20,8 @@ if host_machine.system() != 'windows'
deps = [dl_dep]
else
dl_dep = declare_dependency()
- deps = [dependency('uuid'), dependency('shell32'), dependency('advapi32')]
+ # The MinGW toolchain already links shell32/advapi32 by default.
+ deps = [dependency('uuid')]
Review Comment:
Does this work with Visual Studio?
Could you share error log when we use `shell32` and `advapi32` with MinGW?
##########
c/driver_manager/meson.build:
##########
@@ -32,6 +33,7 @@ adbc_driver_manager_lib = library(
'adbc_driver_manager_api.cc',
],
include_directories: [include_dir, vendor_dir],
+ cpp_args: adbc_export_args,
Review Comment:
Could you use `cpp_shared_args` not `cpp_args` because `-DADBC_EXPORTING` is
needed only for DLL?
```suggestion
cpp_shared_args: adbc_export_args,
```
##########
glib/meson_options.txt:
##########
@@ -29,5 +29,5 @@ option('example',
option('vapi',
type: 'boolean',
- value: false,
+ value: true,
Review Comment:
Could you revert this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
