fornwall commented on PR #4779: URL: https://github.com/apache/arrow-adbc/pull/4779#issuecomment-5657256844
> You should be able to just override the method and skip/no-op the test. Ah, missed that possibility as the method is non-virtual (but that is no blocker with the registration macro), and saw the existing `supports_ingest_float16()` quirk. - Do you think the existing `supports_ingest_float16()` should go away for consistency (to avoid giving the impression that it's a good pattern adding more quirks like that)? - Or perhaps change it to a `supports_ingest(ingest_type)`, if we want to keep the quirk without introducing too many separate quirk methods? - Or is the current status fine and we should just close this (totally fine by me, overriding is acceptable). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
