paleolimbot commented on code in PR #4775:
URL: https://github.com/apache/arrow-adbc/pull/4775#discussion_r4005861893
##########
c/driver/postgresql/postgres_type.h:
##########
@@ -581,6 +586,8 @@ class PostgresTypeResolver {
}
private:
+ friend class PostgresTypeTest_BuiltinResolver_Test;
+
std::unordered_map<uint32_t, PostgresType> mapping_;
// We can't use PostgresTypeId as an unordered map key because there is no
// built-in hasher for an enum on gcc 4.8 (i.e., R 3.6 on Windows).
Review Comment:
FWIW R 3.6 on Windows is no longer in our matrix. Unless gcc 4.8 is
interesting for other reasons, you can probably remove this workaround.
##########
c/driver/postgresql/postgres_type.h:
##########
@@ -581,6 +586,8 @@ class PostgresTypeResolver {
}
private:
+ friend class PostgresTypeTest_BuiltinResolver_Test;
Review Comment:
Either way. Visiting all oid -> PostgresType mappings is a pretty reasonable
thing to do and keeps the test details out of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
