kou commented on code in PR #194:
URL: https://github.com/apache/arrow-swift/pull/194#discussion_r4003822192
##########
Sources/Arrow/ArrowArray.swift:
##########
@@ -229,7 +229,7 @@ public class Date64Array: ArrowArray<Date> {
}
let byteOffset = self.arrowData.stride * Int(index)
- let milliseconds = self.arrowData.buffers[1].rawPointer.advanced(by:
byteOffset).load(as: UInt64.self)
+ let milliseconds = self.arrowData.buffers[1].rawPointer.advanced(by:
byteOffset).load(as: Int64.self)
return Date(timeIntervalSince1970: TimeInterval(milliseconds / 1000))
Review Comment:
Should we change this to `TimeInterval(milliseconds) / 1000` in this PR?
```suggestion
return Date(timeIntervalSince1970: TimeInterval(milliseconds) / 1000)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
