Copilot commented on code in PR #51280:
URL: https://github.com/apache/arrow/pull/51280#discussion_r4008387756
##########
cpp/src/arrow/CMakeLists.txt:
##########
@@ -36,6 +36,20 @@ set(ARROW_STATIC_INSTALL_INTERFACE_LIBS)
if(ARROW_GCS)
if(google_cloud_cpp_storage_SOURCE STREQUAL "SYSTEM")
list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS google-cloud-cpp::storage)
+ elseif(google_cloud_cpp_storage_SOURCE STREQUAL "BUNDLED")
+ if(UNIX)
+ list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS CURL::libcurl)
+ endif()
Review Comment:
The toolchain explicitly treats curl as required for google-cloud-cpp on all
platforms (`cpp/cmake_modules/ThirdpartyToolchain.cmake:3791-3794`), but this
export adds `CURL::libcurl` only under `UNIX`. A Windows consumer of bundled
GCS therefore discovers CURL without linking it, leaving the static archive's
curl references unresolved. Make the bundled-GCS interface dependency
unconditional.
This issue also appears on line 49 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
