domoritz commented on a change in pull request #10361:
URL: https://github.com/apache/arrow/pull/10361#discussion_r637432957
##########
File path: js/tsconfig.json
##########
@@ -7,7 +7,8 @@
"compilerOptions": {
"target": "ESNEXT",
"module": "commonjs",
- "noEmit": true
+ "noEmit": true,
+ "esModuleInterop": true
Review comment:
Ahh, so this is the tsconfig file that editors like VSCode will pick up.
We don't use it to compile things but just for type checking. esModuleInterop
is needed for kleur in the perf tests.
<img width="861" alt="Screen Shot 2021-05-22 at 11 00 08"
src="https://user-images.githubusercontent.com/589034/119236548-e0b5ef80-baec-11eb-92e5-5920a22ecfb2.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/589034/119236548-e0b5ef80-baec-11eb-92e5-5920a22ecfb2.png"](https://user-images.githubusercontent.com/589034/119236548-e0b5ef80-baec-11eb-92e5-5920a22ecfb2.png"){kind=link}