Phoenix500526 opened a new pull request, #11093: URL: https://github.com/apache/arrow-rs/pull/11093
# Which issue does this PR close? - Closes #9269. # Rationale for this change The synchronous Arrow reader has thousands of lines of mixed tests in `arrow_reader/mod.rs`. Grouping them by behavior makes relevant tests and their coverage easier to find. # What changes are included in this PR? Move all 80 existing tests into `parquet/src/arrow/arrow_reader/tests/`, in seven commits: 1. Fixed-file compatibility tests. 2. Reader data-type roundtrips. 3. Schema inference, validation, conversions, and projection. 4. Reader options, row selection, and skipping. 5. Single-column decoding tests and their dedicated test harness. 6. Virtual row-number and row-group-index columns. 7. Remaining internal tests and shared helpers in `tests/mod.rs`. Each group has a short module-level description. Existing test cases, assertions, attributes, and helper behavior are preserved. The shared helper used by async reader tests remains accessible at its existing path. AI assistance: Codex reorganized the existing tests and drafted this PR description. # Are these changes tested? Yes. All 80 synchronous reader tests pass after the move. The following checks also passed: ```text cargo test --locked --offline -p parquet --all-features cargo test --locked --offline -p parquet --lib --no-default-features --features arrow arrow::arrow_reader::tests:: cargo clippy --locked --offline -p parquet --all-targets --all-features -- -D warnings cargo fmt --all -- --check ``` The Arrow-only configuration runs 79 tests because one existing test requires the `snap` feature. Test fixtures matched the base commit's submodule revisions. # Are there any user-facing changes? No. This only reorganizes tests; production behavior and public APIs are unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
