fornwall commented on code in PR #4777:
URL: https://github.com/apache/arrow-adbc/pull/4777#discussion_r4014861075
##########
c/validation/adbc_validation_statement.cc:
##########
@@ -316,11 +316,16 @@ void StatementTest::TestSqlIngestBinaryView() {
}
ASSERT_NO_FATAL_FAILURE(TestSqlIngestType<std::vector<std::byte>>(
- NANOARROW_TYPE_LARGE_BINARY,
- {std::nullopt, std::vector<std::byte>{},
+ NANOARROW_TYPE_BINARY_VIEW,
+ {std::nullopt,
+ // Empty vectors trigger a null-pointer memcpy in nanoarrow.
+ // TODO: Restore after vendoring the fix:
+ // https://github.com/apache/arrow-nanoarrow/pull/940
+ // std::vector<std::byte>{},
Review Comment:
There has not been a `nanoarrow` release with the fix yet.
We could bump our vendored `nanoarrow` version to the unreleased version,
but builds without `ADBC_WITH_VENDORED_NANOARROW` will have the issue unless
the system `nanoarrow` is the unreleased version.
Which might be totally fine - what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
