paleolimbot commented on code in PR #942:
URL: https://github.com/apache/arrow-nanoarrow/pull/942#discussion_r4018309985
##########
src/nanoarrow/common/array_test.cc:
##########
@@ -2441,6 +2441,70 @@ TEST(ArrayTest, ArrayViewTestBasic) {
ArrowArrayViewReset(&array_view);
}
+TEST(ArrayTest, ArrayViewTestMissingValidityUnknownNullCount) {
+ struct ArrowError error;
+
+ // A missing validity buffer with null_count == -1 is valid
+ int32_t values[] = {11, 12, 13};
+ const void* buffers[] = {nullptr, values};
+
+ nanoarrow::UniqueArray array;
+ array->length = 2;
+ array->offset = 1;
+ array->null_count = -1;
+ array->n_buffers = 2;
+ array->n_children = 0;
+ array->buffers = buffers;
+ array->children = nullptr;
+ array->dictionary = nullptr;
+ array->release = [](struct ArrowArray*) {};
+
+ nanoarrow::UniqueArrayView array_view;
+ ArrowArrayViewInitFromType(array_view.get(), NANOARROW_TYPE_INT32);
+ ASSERT_EQ(ArrowArrayViewSetArray(array_view.get(), array.get(), &error),
NANOARROW_OK)
+ << error.message;
+ EXPECT_EQ(
+ ArrowArrayViewValidate(array_view.get(),
NANOARROW_VALIDATION_LEVEL_FULL, &error),
+ NANOARROW_OK)
+ << error.message;
+ EXPECT_EQ(ArrowArrayViewGetBufferView(array_view.get(), 0).size_bytes, 0);
+ EXPECT_EQ(ArrowArrayViewComputeNullCount(array_view.get()), 0);
+ EXPECT_EQ(ArrowArrayViewIsNull(array_view.get(), 0), 0);
+ EXPECT_EQ(ArrowArrayViewIsNull(array_view.get(), 1), 0);
+ EXPECT_EQ(ArrowArrayViewGetIntUnsafe(array_view.get(), 0), 12);
+ EXPECT_EQ(ArrowArrayViewGetIntUnsafe(array_view.get(), 1), 13);
+
+ // A missing validity buffer with null_count > 0 is still an error
+ array->null_count = 1;
+ EXPECT_EQ(ArrowArrayViewSetArray(array_view.get(), array.get(), &error),
EINVAL);
+ EXPECT_STREQ(error.message,
+ "Expected int32 array buffer 0 to have size >= 1 bytes but
found buffer "
+ "with 0 bytes");
+
+ // Same for a string array (["a", "bb", "ccc"])
+ int32_t offsets[] = {0, 1, 3, 6};
+ const void* string_buffers[] = {nullptr, offsets, "abbccc"};
+ array->null_count = -1;
+ array->n_buffers = 3;
+ array->buffers = string_buffers;
+
+ nanoarrow::UniqueArrayView string_view;
+ ArrowArrayViewInitFromType(string_view.get(), NANOARROW_TYPE_STRING);
+ ASSERT_EQ(ArrowArrayViewSetArray(string_view.get(), array.get(), &error),
NANOARROW_OK)
+ << error.message;
+ EXPECT_EQ(
+ ArrowArrayViewValidate(string_view.get(),
NANOARROW_VALIDATION_LEVEL_FULL, &error),
+ NANOARROW_OK)
+ << error.message;
+ EXPECT_EQ(ArrowArrayViewGetBufferView(string_view.get(), 0).size_bytes, 0);
+ EXPECT_EQ(ArrowArrayViewComputeNullCount(string_view.get()), 0);
+ EXPECT_EQ(ArrowArrayViewGetStringUnsafe(string_view.get(), 0), "bb"_asv);
+ EXPECT_EQ(ArrowArrayViewGetStringUnsafe(string_view.get(), 1), "ccc"_asv);
+
+ array->null_count = 1;
+ EXPECT_EQ(ArrowArrayViewSetArray(string_view.get(), array.get(), &error),
EINVAL);
Review Comment:
Can you to use the exact same array as above and just modify the null count?
I don't think we need to use a different type here to cover the changed lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
