alamb commented on code in PR #11088:
URL: https://github.com/apache/arrow-rs/pull/11088#discussion_r4019850801
##########
parquet/src/bloom_filter/mod.rs:
##########
@@ -578,6 +578,32 @@ impl Sbbf {
self.0.len()
}
+ /// Estimate the false positive probability (FPP) of this filter at its
current size.
+ ///
+ /// A membership check tests 8 bits within a single 256-bit block, so with
an average
Review Comment:
I think we could reduce the verbosity of this comment to make it easier to
read
For example, the details of how the membership test works seems unecessary.
It seems like the core message here would be that "this is the same estimate
..." and "this lets a caller inspect ..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
