Jefffrey commented on code in PR #11047:
URL: https://github.com/apache/arrow-rs/pull/11047#discussion_r4034443794


##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -1127,9 +1127,26 @@ impl ArrowReaderMetadata {
             )));
         }
 
+        // Virtual columns are appended to `field_levels` and counted in the 
length check
+        // above, so the reported schema has to carry them too.
+        let schema = if virtual_columns.is_empty() {
+            supplied_schema
+        } else {
+            let fields = supplied_schema

Review Comment:
   i notice here we construct via `field_levels`:
   
   
https://github.com/apache/arrow-rs/blob/0a5979560ac67135134c3618519b9b7384edf4d2/parquet/src/arrow/schema/mod.rs#L75-L99
   
   - line 97
   
   is this equivalent?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to