neilconway commented on code in PR #11002:
URL: https://github.com/apache/arrow-rs/pull/11002#discussion_r4038771318
##########
arrow-array/src/types.rs:
##########
@@ -1418,8 +1418,12 @@ pub trait DecimalType:
/// "Decimal32", "Decimal64", "Decimal128" or "Decimal256", for use in
error messages
const PREFIX: &'static str;
- /// Formats the decimal value with the provided precision and scale
- fn format_decimal(value: Self::Native, precision: u8, scale: i8) -> String;
+ /// Formats `value` with `scale` fractional digits. The value is always
Review Comment:
`write_decimal` is also public and already writes into a `fmt::Write`. Happy
to add a `DecimalType`/`PrimitiveArray`-level wrapper in a follow-up if you
think it's worth having.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]