etseidl commented on code in PR #11123:
URL: https://github.com/apache/arrow-rs/pull/11123#discussion_r4039935908


##########
arrow/benches/coalesce_kernels.rs:
##########
@@ -1021,6 +1079,23 @@ impl DataStreamBuilder {
                     self.max_string_len,
                 )) // TODO seed
             }
+            DataType::FixedSizeBinary(size) => {
+                let size = *size as usize;

Review Comment:
   I guess my only nit is do we want to encapsulate this logic as is done for 
all the other arms?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to