thisisnic commented on code in PR #50367:
URL: https://github.com/apache/arrow/pull/50367#discussion_r4042517853
##########
r/R/dataset-write.R:
##########
@@ -194,7 +197,7 @@ write_dataset <- function(
path_and_fs <- get_path_and_filesystem(path)
dots <- list(...)
- if (format %in% c("txt", "text") && !any(c("delimiter", "delim") %in%
names(dots))) {
+ if (format == "txt" && !any(c("delimiter", "delim") %in% names(dots))) {
Review Comment:
Yeah, mapping "text" to "csv" is to mirror `open_dataset()` but it's a bit
weird.
"txt" is what `write_delim_dataset()` passes internally and it always sends
a delimiter, so I've left that check alone rather than also defaulting it to
comma.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
