kylebarron commented on code in PR #11125:
URL: https://github.com/apache/arrow-rs/pull/11125#discussion_r4046646243
##########
arrow-array/src/ffi_stream.rs:
##########
@@ -214,6 +250,33 @@ impl FFI_ArrowArrayStream {
}
}
+ /// Returns the producer-provided callback that writes this stream's
schema, if any.
+ ///
+ /// The callback must be invoked with a pointer to the stream it was read
from.
Review Comment:
Right, essentially the safety note should be attached to the _returned_
unsafe function rather than this "safe" function.
But for clarity perhaps better to mark this comment as `# Safety` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
