HuaHuaY commented on code in PR #50252:
URL: https://github.com/apache/arrow/pull/50252#discussion_r4055984605
##########
cpp/src/arrow/extension/parquet_variant.h:
##########
@@ -18,15 +18,31 @@
#pragma once
#include <string>
+#include <string_view>
#include "arrow/extension_type.h"
#include "arrow/util/visibility.h"
namespace arrow::extension {
+/// \brief The extension name for the Variant extension type.
+inline constexpr std::string_view kVariantExtensionName =
"arrow.parquet.variant";
+
class ARROW_EXPORT VariantArray : public ExtensionArray {
public:
using ExtensionArray::ExtensionArray;
+
+ /// \brief The metadata child array.
+ std::shared_ptr<Array> metadata() const;
+
+ /// \brief The residual value child array, or null if it is absent from
storage.
Review Comment:
I think what you said is this thread
https://github.com/apache/parquet-format/pull/591 which was opened by me. The
final conclusion is that, when reading, we need to handle invalid files that
lack a "value" field. I will make the comments clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
