Rich-T-kid commented on code in PR #11145:
URL: https://github.com/apache/arrow-rs/pull/11145#discussion_r4058297257
##########
arrow-array/src/array/map_array.rs:
##########
@@ -216,11 +216,23 @@ impl MapArray {
}
/// Returns a reference to the keys of this map
+ ///
+ /// Note: The map array may not refer to all keys in the returned array.
+ /// For example, after slicing via [`Self::slice`], the returned array may
+ /// contain keys both before and after the slice. Use
[`Self::value_offsets`]
+ /// to determine the range of keys for each map. These offsets index into
+ /// the returned array and may not start at zero.
Review Comment:
```suggestion
/// Returns a reference to all the keys of this map
/// this includes keys that may have been [`Self::slice`]'ed off
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
