zeroshade opened a new pull request, #1332: URL: https://github.com/apache/arrow-go/pull/1332
## What changed - add an `execFixture` helper with an explicit one-minute setup deadline - use it for all ten large Flight SQL row fixture inserts - preserve the driver's five-second default timeout and the cancellation tests' existing query deadlines ## Why The ASan/no-ASM job in https://github.com/apache/arrow-go/actions/runs/35436626598/job/106171165623?pr=1328 failed while inserting the 6,000-row test fixture, before the cancellation behavior under test began. Context-free `db.Exec` inherited the suite's five-second driver timeout, and the instrumented insert exceeded that deadline. A sibling cancellation test failed at the same setup boundary in another matrix job. Giving fixture construction its own bounded context separates setup cost from the behavior timeout being tested without changing production driver behavior. ## Verification ```text go test -asan -short -tags assert,test,noasm ./arrow/flight/flightsql/driver -run '^TestSqliteBackend/TestRowsInterruptionByContext(ManualCancellation|Timeout)(Stmt)?$' -count=25 ok github.com/apache/arrow-go/v18/arrow/flight/flightsql/driver 250.547s go test -asan -short -tags assert,test,noasm ./arrow/flight/flightsql/driver -run '^TestSqliteBackend/TestRows' -count=10 ok github.com/apache/arrow-go/v18/arrow/flight/flightsql/driver 191.764s go test -asan -short -tags assert,test,noasm ./arrow/flight/flightsql/driver ok github.com/apache/arrow-go/v18/arrow/flight/flightsql/driver 20.363s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
