kou commented on code in PR #51276:
URL: https://github.com/apache/arrow/pull/51276#discussion_r4066711597
##########
ruby/red-arrow/ext/arrow/arrow.cpp:
##########
@@ -103,6 +103,12 @@ extern "C" void Init_arrow() {
reinterpret_cast<rb::RawMethod>(red_arrow::array_values),
0);
+ // Use Array#values instead of the GObject property. The physical child
+ // array is still available as values_raw.
+ auto cArrowRunEndEncodedArray =
+ rb_const_get_at(mArrow, rb_intern("RunEndEncodedArray"));
+ rb_remove_method(cArrowRunEndEncodedArray, "values");
Review Comment:
Ah, let's rename the `values` property to `physical_values` in Apache Arrow
GLib as a separated task.
(`garrow_run_end_encoded_array_get_values()` should be renamed to
`...get_physical_values()` too with deprecation.)
Could you open a new issue for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
