Jefffrey opened a new issue, #11166: URL: https://github.com/apache/arrow-rs/issues/11166
### Is your feature request related to a problem or challenge? Currently we use `unused_crate_dependencies` lint as part of CI to check for unused dependencies: https://github.com/apache/arrow-rs/blob/b825e98ff68a20e875ecbf1771e5fab0878271d9/.github/workflows/arrow.yml#L214-L261 - From https://github.com/apache/arrow-rs/issues/6796 and https://github.com/apache/arrow-rs/pull/6804 But this is quite verbose, not to mention we'd have to copy this action code for each crate we want to run it for (it seems we don't do it for any of the parquet crates for example). It also seems to ignore tests & benches so its not applicable for dev dependencies. ### Describe the solution you'd like Consider using [cargo machete](https://github.com/bnjbvr/cargo-machete) instead. Datafusion uses it: https://github.com/apache/datafusion/blob/0576a0b400437ade5a6f3b102465d954a539f263/.github/workflows/dependencies.yml#L60-L76 And although there was concern raised in the original issue for why `unused_crate_dependencies` lint was preferred: https://github.com/apache/arrow-rs/issues/6796#issuecomment-2499081798 I tried running it locally with `cargo machete --with-metadata` and it detected only two false positives, relating to tokio/futures/bytes being used for doc tests, which seems a pretty decent false positive rate. ### Describe alternatives you've considered _No response_ ### Additional context We'd also be able to cleanup allows like this if we remove CI check for `unused_crate_dependencies` lint: https://github.com/apache/arrow-rs/blob/b825e98ff68a20e875ecbf1771e5fab0878271d9/arrow-flight/src/lib.rs#L54-L55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
