besquared opened a new pull request, #4798: URL: https://github.com/apache/arrow-adbc/pull/4798
## Summary Carry libpq PQfmod into numeric result-field metadata as POSTGRESQL:typmod. The proposed spelling follows POSTGRESQL:type and is open to review. Numeric values remain UTF-8 with the existing opaque extension; there is no numeric conversion, inference, buffering, or additional query. The modifier is preserved by COPY result description and the non-COPY reader. Only numeric fields with an explicitly supplied modifier receive the key; -1 remains distinguishable from absent metadata. Parameter schemas and catalog discovery are unchanged. ## Tests - Built the PostgreSQL driver and both native test executables against upstream main with GCC 13.3, Debug, warnings-as-errors. - PostgresTypeTest.* and PostgresStatementTest.NumericTypeModifier: 9 passed against PostgreSQL over a read-only connection. - PostgreSQL COPY reader/writer test executable: 75 passed. - Integration coverage compares ExecuteSchema and execution for COPY on/off, declared numeric, unconstrained numeric, expression results, NULL, empty results, and unaffected integer columns; checks unchanged string values. - Type-level tests include negative-scale and scale-greater-than-precision modifiers. - clang-format 18.1.7, cpplint 2.0.2 with repository options, and git diff --check passed. The complete multi-language pre-commit suite and full PostgreSQL integration suite were not run. Related: the PQfmod discussion in #758 and numeric metadata in #4687. This exposes existing result metadata and does not implement #1514 or #1521. Closes #4797 Assisted-by: OpenAI Codex -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
