taepper commented on code in PR #51458:
URL: https://github.com/apache/arrow/pull/51458#discussion_r4070978714
##########
cpp/src/arrow/status_test.cc:
##########
@@ -28,6 +28,13 @@
namespace arrow {
+// Keep this function on top of file to minimize line number churn.
+template <typename StatusLike>
+Status ReturnNotOk(StatusLike&& status_like, int recursion = 0) {
+ RETURN_NOT_OK(status_like);
+ return Status::OK();
+}
Review Comment:
It was initially not clear to me that this is because of the line number
tested in `TEST(StatusTest, ReturnIfNotOk)`, and I was confused why we wanted
this code segment's position stable
Maybe not important, but
`Keep at top of the file to keep line number in asserted error message
stable` is more explicit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
