jorisvandenbossche commented on code in PR #51404:
URL: https://github.com/apache/arrow/pull/51404#discussion_r4072175546
##########
python/pyarrow/tests/test_pandas.py:
##########
@@ -5006,7 +5006,7 @@ def test_does_not_mutate_timedelta_dtype():
assert np.dtype(np.timedelta64) == expected
- df = pd.DataFrame({"a": [np.timedelta64()]})
+ df = pd.DataFrame({"a": [np.timedelta64(0, "s")]})
Review Comment:
While this makes the test run without the warning, I am not sure if then the
surrounding asserts still make sense.
One thing to do is also to change `expected = np.dtype('m8')` to use
"m8[s]", but no idea if that would then still have produced the initial bug
(the reason this test was added, https://github.com/apache/arrow/pull/13553)
##########
python/pyarrow/tests/test_dlpack.py:
##########
@@ -335,24 +341,24 @@ def test_dlpack_not_supported():
arr = pa.array([1, None, 3])
with pytest.raises(TypeError, match="Can only use DLPack "
"on arrays with no nulls."):
- np.from_dlpack(arr)
+ np.from_dlpack(DLPackForwarder(arr, max_version=(1, 0)))
Review Comment:
If leaving the DLPack depr question for a separate issue, I would maybe also
leave out any of the dlpack-related changes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
