taepper commented on PR #51460: URL: https://github.com/apache/arrow/pull/51460#issuecomment-5784769778
Did this change all usages of `std::is_same_v` in the codebase to `std::same_as`? What is the rationale behind this? `std::is_same_v` is a _type trait_ that evaluates to `true` or `false`, while `std::same_as` is a _concept_ that is used define type constrains. Do you think it is advisable to e.g. replace this also in imperative code within `template` functions? If so, why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
