cetra3 commented on code in PR #11159:
URL: https://github.com/apache/arrow-rs/pull/11159#discussion_r4077733069
##########
parquet/src/file/metadata/parser.rs:
##########
@@ -244,40 +245,45 @@ pub(crate) fn decode_metadata(
/// Required, Optional, Skip).
/// * `offset_index_policy` - The policy for handling offset index parsing
(e.g.,
/// Required, Optional, Skip).
-/// * `bytes` - The byte slice containing the page index data.
+/// * `bytes` - [`PushBuffers`] that should have already been populated with
the bytes containing
+/// the page indexes.
/// * `start_offset` - The offset where `bytes` begin in the file.
pub(crate) fn parse_page_index(
metadata: &mut ParquetMetaData,
column_index_policy: PageIndexPolicy,
offset_index_policy: PageIndexPolicy,
- bytes: &Bytes,
- start_offset: u64,
+ column_index_mask: &ColumnChunkMask,
+ offset_index_mask: &ColumnChunkMask,
+ bytes: &PushBuffers,
) -> crate::errors::Result<()> {
if column_index_policy == PageIndexPolicy::Skip && offset_index_policy ==
PageIndexPolicy::Skip
{
return Ok(());
}
let num_row_groups = metadata.num_row_groups();
let num_columns = metadata.file_metadata().schema_descr().num_columns();
- let mut builder = PageIndexBuilder::default();
+ let mut builder = PageIndexBuilder::new_with_mask(
Review Comment:
Won't this preallocate stuff on skip?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
