efegokdemir opened a new pull request, #946: URL: https://github.com/apache/arrow-nanoarrow/pull/946
## Summary Fixes #945 by making validation of Arrow offset buffers safe for unaligned C Data Interface buffers. ## Changes - Add byte-based `memcpy` helpers for reading 32-bit and 64-bit buffer values. - Use the helpers for default and full offset validation, including string, list, and large variants. - Add regression coverage for unaligned string and large-string offset buffers. ## Testing - Upstream reproducer with Clang UBSan: reproduced misaligned-load failure. - Patched bundle with Clang UBSan: passed; `ArrowArrayViewValidate: 0` with no UBSan diagnostics. - `cc -std=c99 -Wall -Wextra -Werror -I/tmp/nanoarrow945-dist-fixed/include -Isrc -fsyntax-only src/nanoarrow/common/array.c`: passed. - `git diff --check`: passed. - Full CMake/GoogleTest suite: not run because CMake and GoogleTest are not installed in the local environment. ## Notes The change keeps the existing validation results and avoids typed dereferences of externally supplied offset buffers. AI assistance was used during investigation and implementation; the submitter reviewed the changed lines and validation results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
