alamb commented on code in PR #50839: URL: https://github.com/apache/arrow/pull/50839#discussion_r4085510121
########## docs/source/format/Columnar.rst: ########## @@ -878,10 +884,10 @@ Dense union represents a mixed-type array with 5 bytes of overhead for each value. Its physical layout is as follows: * One child array for each type -* Types buffer: A buffer of 8-bit signed integers. Each type in the - union has a corresponding type id whose values are found in this - buffer. A union with more than 128 possible types can be modeled as - a union of unions. +* Types buffer: A buffer of 8-bit signed integers, indicating the type + id of each slot. Note that these type ids are not necessarily the + same as the child array index (see above). A union with more than 128 Review Comment: It would be nice to use "child array offset" here to be consistent with the text above (or change above to be "child array index") -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
