adriangb commented on PR #11031: URL: https://github.com/apache/arrow-rs/pull/11031#issuecomment-5819180850
> > suggest that we keep the current behavior (always clear the locations that the writer did not write), add the `breaking change` label, and close #6464. Then we document two points on `ParquetMetaDataWriter`: to include the page index, load it before you write; to cache the footer only, store the raw footer bytes, which already contain the original offsets. This is simpler than a boolean, and the output is always self-consistent. If someone needs the old behavior later, we can add the option then. If needed we can break that out into a cleanup PR. Thoughts? > > Well, I've got too much work stacked on this PR to wait for the breaking API window to open again 😅. I think what I have now works; it keeps the current behavior, but allows for clearing the index info if desired. We can change the default behavior to clearing the indexes later. I think even as is, we might be able to close #6464. @alamb any thoughts on that score? Sounds good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
