Jefffrey commented on code in PR #11208:
URL: https://github.com/apache/arrow-rs/pull/11208#discussion_r4102994960
##########
parquet/src/file/metadata/reader.rs:
##########
@@ -688,10 +688,9 @@ impl ParquetMetaDataReader {
} else {
let metadata_start = suffix_len - metadata_offset;
let slice = suffix.slice(metadata_start..suffix_len - FOOTER_SIZE);
- Ok((
- self.decode_footer_metadata(slice, file_size, footer)?,
- Some((0, suffix.slice(..metadata_start))),
- ))
+ // `MetadataSuffixFetch` does not expose the file size, so the
file offset of
+ // the bytes preceding the metadata is unknown and they cannot be
reused safely.
+ Ok((self.decode_footer_metadata(slice, file_size, footer)?, None))
Review Comment:
this function now always returns `None` for the 2nd tuple arg, perhaps
simplify the return type to omit this option now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
