rok commented on code in PR #51461:
URL: https://github.com/apache/arrow/pull/51461#discussion_r4105978589
##########
python/pyarrow/tests/parquet/test_dataset.py:
##########
@@ -1312,6 +1312,31 @@ def file_visitor(written_file):
assert paths_written_set == expected_paths
+def test_write_table_options_in_make_write_options():
+ import pyarrow.dataset as ds
+
+ not_writer_args = {"table", "where", "row_group_size", "filesystem",
"flavor"}
+ options = {
+ name: parameter.default
+ for name, parameter in
inspect.signature(pq.write_table).parameters.items()
+ if name not in not_writer_args
+ and parameter.kind != inspect.Parameter.VAR_KEYWORD
+ }
+ ds.ParquetFileFormat().make_write_options(**options)
Review Comment:
Perhaps add a comment with motivation here to explain why this should fail
for when it does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
